Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve extra param issue in boardsource/5x12 via keymap #10501

Merged
merged 11 commits into from
Oct 1, 2020
Merged

resolve extra param issue in boardsource/5x12 via keymap #10501

merged 11 commits into from
Oct 1, 2020

Conversation

gwillad
Copy link
Contributor

@gwillad gwillad commented Oct 1, 2020

Description

via keymap for boardsource 5x12 failed to compile because Layer 3 had an extra param in the LAYOUT_ortho_5x12 function. This resolved this issue

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • unmarked issue

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Adam Gwilliam and others added 11 commits September 4, 2020 21:24
add via support for boardsource/5x12
07bd60f
make product id for 5x12 unique (there is already an 0x0512) by setti…
d125075 
…ng it to 0x5012
un-swap the readme's for 3x4 and 5x12
7715a08
@gwillad @noroadsleft
Update keyboards/boardsource/5x12/config.h
4ba8419 
update vendor id

Co-authored-by: James Young <[email protected]>
@gwillad @noroadsleft
Update keyboards/boardsource/5x12/keymaps/via/keymap.c
c811754 
use correct number of layers for VIA

Co-authored-by: James Young <[email protected]>
update product id to use same pattern as others
7b5e443
@gwillad @nooges
Update keyboards/boardsource/5x12/keymaps/via/readme.md
d4feead 
Co-authored-by: Danny <[email protected]>
@gwillad @noroadsleft
Update keyboards/boardsource/5x12/keymaps/via/readme.md
de6cdc7 
Co-authored-by: James Young <[email protected]>
Merge branch 'master' of github.com:gwillad/qmk_firmware into 5x12
5230e9d
error in compiling
d7b986a
Merge branch '5x12' of github.com:gwillad/qmk_firmware into 5x12
e217925
@gwillad gwillad mentioned this pull request Oct 1, 2020
Merged
6 tasks
@fauxpark fauxpark requested a review from a team October 1, 2020 17:11
Erovia
Erovia approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@Erovia Erovia merged commit 8fbea13 into qmk:master Oct 1, 2020
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@gwillad @noroadsleft
@nooges @rgoulter
resolve extra param issue in boardsource/5x12 via keymap (qmk#10501)
1eed37b 
Co-authored-by: James Young <[email protected]>
Co-authored-by: Danny <[email protected]>
Co-authored-by: Adam Gwilliam <[email protected]>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@gwillad @noroadsleft @nooges
resolve extra param issue in boardsource/5x12 via keymap (qmk#10501)
76440a4 
Co-authored-by: James Young <[email protected]>
Co-authored-by: Danny <[email protected]>
Co-authored-by: Adam Gwilliam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
bug keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwillad @Erovia @fauxpark